Add a new home property to a change listener

[enkonyito]

The setProperty method allow to set a new property associated with a home.
But can this property be taken into account by the addPropertyChangeListener method without returning an IllegalArgumentException if you use valueOf (String name)?

With this code:

Code: Select all

this.home.addPropertyChangeListener(Home.Property.valueOf(ENHANCED_EXTERNAL_BRIGHTNESS),
	    new PropertyChangeListener() {
	    	public void propertyChange(PropertyChangeEvent ev) {
	    		isEnhancedExternalBrightness = Boolean.parseBoolean(home.getProperty(ENHANCED_EXTERNAL_BRIGHTNESS));
	    		externalBrightnessEnabledCheckBox.setSelected(isEnhancedExternalBrightness);
	    	}
    	});

I have this error:

Code: Select all

Exception in thread "AWT-EventQueue-0" java.lang.IllegalArgumentException: No enum constant com.eteks.sweethome3d.model.Home.Property.enhancedExternalBrightness

[Puybaret]

The method [font=courier new]valueOf[/font] of an enum takes into account only values of the enum that exist.
The main problem comes from the fact that enums are [font=courier new]final[/font], and using enums for these properties is actually a wrong idea I had [:(]

[enkonyito]

I wanted to bind the enhance external brightness option of the photo panel to the video panel.
The alternative would be an implicit selection from the photo panel only.

The main problem comes from the fact that enums are [font=courier new]final[/font], and using enums for these properties is actually a wrong idea I had [:(]

I do not know if other developers needed to add a new home property to existing ones but if there is a solution for it to be possible without too much changing the source code, why not?